Freddy Rolland has posted comments on this change.

Change subject: hsm: Support GUID list param in GetDeviceList
......................................................................


Patch Set 8:

(2 comments)

https://gerrit.ovirt.org/#/c/40661/8//COMMIT_MSG
Commit Message:

Line 7: hsm: Support GUID list param in GetDeviceList
Line 8: 
Line 9: Add support for additional optional parameter of a list of GUIDs
Line 10: to GetDeviceList.
Line 11: 
> Please explain why we need this, which flows are going to use this feature?
Done
Line 12: Examples:
Line 13:     getDeviceList
Line 14:         return all devices
Line 15: 


https://gerrit.ovirt.org/#/c/40661/8/client/vdsClient.py
File client/vdsClient.py:

Line 2205:                           ('[storageType]',
Line 2206:                            '[<devlist>]',
Line 2207:                            'List of all block devices (optionally - 
matching '
Line 2208:                            'storageType, optionally - of each device 
listed).'
Line 2209:                            '\n\tgetDeviceList'
> Use separate strings for each line, see downoadImage for example.
Done
Line 2210:                            '\n\t\treturn all devices'
Line 2211:                            '\n\tgetDeviceList FCP'
Line 2212:                            '\n\t\treturn only FCP devices'
Line 2213:                            '\n\tgetDeviceList ISCSI guid1 guid2'


-- 
To view, visit https://gerrit.ovirt.org/40661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic173d94a132e617ae97353d38520a86bede657d7
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <[email protected]>
Gerrit-Reviewer: Fred Rolland <[email protected]>
Gerrit-Reviewer: Freddy Rolland <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to