Nir Soffer has posted comments on this change. Change subject: hsm: Support GUID list param in GetDeviceList ......................................................................
Patch Set 9: Code-Review+1 (2 comments) https://gerrit.ovirt.org/#/c/40661/9//COMMIT_MSG Commit Message: Line 24: getDeviceList FCP Line 25: return only FCP devices Line 26: Line 27: getDeviceList ISCSI guid1 guid2 Line 28: return info for guid1 and guid2, assuming ISCSI type Fred, the commit message needs some formatting improvements - do you want me to post the next version improving formatting? Line 29: Line 30: Change-Id: Ic173d94a132e617ae97353d38520a86bede657d7 Line 31: Bug-Url:https://bugzilla.redhat.com/609689 https://gerrit.ovirt.org/#/c/40661/9/client/vdsClient.py File client/vdsClient.py: Line 2254: ' getDeviceList FCP', Line 2255: ' return only FCP devices', Line 2256: ' getDeviceList ISCSI guid1 guid2', Line 2257: ' return info for guid1 and guid2', Line 2258: ' , assuming ISCSI type' Looks much better now, we can actually see the final output. Line 2259: )), Line 2260: 'getDevicesVisibility': (serv.getDevicesVisibility, Line 2261: ('<devlist>', Line 2262: 'Get visibility of each device listed' -- To view, visit https://gerrit.ovirt.org/40661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic173d94a132e617ae97353d38520a86bede657d7 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <[email protected]> Gerrit-Reviewer: Fred Rolland <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
