Adam Litke has posted comments on this change. Change subject: StorageDomainManifest: move BlockSD.getVSize ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/41994/9/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 416: """ Return the block volume size in bytes. """ Line 417: try: Line 418: size = _tellEnd(lvm.lvPath(self.sdUUID, volUUID)) Line 419: except IOError as e: Line 420: if e.errno == os.errno.ENOENT: Need to test this branch too. Line 421: # Inactive volume has no /dev entry. Fallback to lvm way. Line 422: size = lvm.getLV(self.sdUUID, volUUID).size Line 423: else: Line 424: self.log.warn("Could not get size for vol %s/%s", -- To view, visit https://gerrit.ovirt.org/41994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib00eba218cfb4af201aebcdc5071f95164c31687 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
