Nir Soffer has posted comments on this change. Change subject: StorageDomainManifest: move BlockSD.getVSize ......................................................................
Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/41994/12/tests/manifest_tests.py File tests/manifest_tests.py: Line 41: def test_getvsize(self): Line 42: with namedTemporaryDir() as path: Line 43: manifest = self.make_manifest(path) Line 44: imguuid, voluuid = make_volume(manifest.domaindir, VOLSIZE) Line 45: self.assertEqual(VOLSIZE, manifest.getVSize(imguuid, voluuid)) This will use the real oop object - I wonder how this test can pass. Maybe oop is using in-process functions by defualt? Line 46: Line 47: def make_manifest(self, path): Line 48: sduuid = str(uuid.uuid4()) Line 49: domain_path = os.path.join(path, sduuid) -- To view, visit https://gerrit.ovirt.org/41994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib00eba218cfb4af201aebcdc5071f95164c31687 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
