Nir Soffer has posted comments on this change.
Change subject: gluster: Verify volume is Replica 3
......................................................................
Patch Set 27: -Code-Review -Verified
replica1 test fails when running on machine with custom replica 1 setting -
typical developer machine.
======================================================================
FAIL: test_allowed_gluster_replica_count(kw='1')
(storageServerTests.GlusterFSConnectionTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/root/src/vdsm/tests/testlib.py", line 64, in wrapper
return f(self, *args)
File "/root/src/vdsm/tests/monkeypatch.py", line 133, in wrapper
return f(*args, **kw)
File "/root/src/vdsm/tests/storageServerTests.py", line 149, in
test_allowed_gluster_replica_count
gluster.validate)
AssertionError: UnsupportedGlusterVolumeReplicaCountError not raised
The test must mock the configuration - we don't want test to depend on the
current configuration on a host.
--
To view, visit https://gerrit.ovirt.org/41931
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ala Hino <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Darshan N <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
