Nir Soffer has posted comments on this change. Change subject: gluster: Verify volume is Replica 3 ......................................................................
Patch Set 30: (1 comment) https://gerrit.ovirt.org/#/c/41931/30/tests/storageServerTests.py File tests/storageServerTests.py: Line 132: options=user_options) Line 133: self.assertEquals(gluster.options, user_options) Line 134: Line 135: @MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm()) Line 136: @MonkeyPatch(GlusterFSConnection, 'ALLOWED_REPLICA_COUNTS', ('3')) ('3') is not a tuple with one item, but the string '3'. What you want is ('3',) Line 137: @permutations([['1', False], ['2', False], ['3', True], ['4', False]]) Line 138: def test_allowed_gluster_replica_count(self, replica_count, supported): Line 139: Line 140: def glusterVolumeInfo(volumeName=None, remoteServer=None): -- To view, visit https://gerrit.ovirt.org/41931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
