Nir Soffer has posted comments on this change. Change subject: StorageDomainManifest: move path getters ......................................................................
Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/41995/12/tests/manifest_tests.py File tests/manifest_tests.py: Line 45: imguuid, voluuid = make_volume(manifest.domaindir, VOLSIZE) Line 46: self.assertEqual(VOLSIZE, manifest.getVSize(imguuid, voluuid)) Line 47: Line 48: def test_getisodomainimagesdir(self): Line 49: with namedTemporaryDir() as path: Do we need always temporary directory? Can use unbound manifest for testing? Line 50: manifest = self.make_manifest(path) Line 51: isopath = os.path.join(manifest.domaindir, sd.DOMAIN_IMAGES, Line 52: sd.ISO_IMAGE_UUID) Line 53: self.assertEquals(isopath, manifest.getIsoDomainImagesDir()) -- To view, visit https://gerrit.ovirt.org/41995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bb49591357e0ae77268789da78e8504864a8057 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
