Nir Soffer has posted comments on this change. Change subject: StorageDomainManifest: move path getters ......................................................................
Patch Set 13: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/41995/13/vdsm/storage/sd.py File vdsm/storage/sd.py: Line 320: """ Line 321: return os.path.join(self.domaindir, DOMAIN_IMAGES, ISO_IMAGE_UUID) Line 322: Line 323: def getMDPath(self): Line 324: if self.domaindir: Is this possible? I would like to eliminate the possible None return value. Line 325: return os.path.join(self.domaindir, DOMAIN_META_DATA) Line 326: return None Line 327: Line 328: -- To view, visit https://gerrit.ovirt.org/41995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bb49591357e0ae77268789da78e8504864a8057 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
