Nir Soffer has posted comments on this change. Change subject: StorageDomainManifest: introduce class heirarchy ......................................................................
Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/41993/13/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 417: manifestClass = BlockStorageDomainManifest Line 418: Line 419: def __init__(self, sdUUID): Line 420: manifest = self.manifestClass(sdUUID) Line 421: manifest.bind() Do you have code that must create a manifest without binding? Line 422: sd.StorageDomain.__init__(self, manifest) Line 423: lvm.activateLVs(self.sdUUID, SPECIAL_LVS) Line 424: self.metavol = lvm.lvPath(self.sdUUID, sd.METADATA) Line 425: -- To view, visit https://gerrit.ovirt.org/41993 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia275424a8d423722efb229a4d8545f035fe5fa51 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
