Adam Litke has posted comments on this change. Change subject: StorageDomainManifest: introduce class heirarchy ......................................................................
Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/41993/14/vdsm/storage/sd.py File vdsm/storage/sd.py: Line 304: StorageDomainManifest objects can be constructed without side effects Line 305: but before the object can be used it must be bound to the storage it Line 306: represents. The bind method must be implemented by descendant classes. Line 307: """ Line 308: raise NotImplementedError() > We don't need bind now. hmm, thought I removed this... Not sure how it sneaked in. Line 309: Line 310: @property Line 311: def oop(self): Line 312: return oop.getProcessPool(self.sdUUID) -- To view, visit https://gerrit.ovirt.org/41993 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia275424a8d423722efb229a4d8545f035fe5fa51 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
