Dan Kenigsberg has posted comments on this change. Change subject: Modifying vdsm supported cluster end engine versions for el6 and el7 ......................................................................
Patch Set 3: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/42247/3/vdsm/dsaversion.py.in File vdsm/dsaversion.py.in: Line 38: } Line 39: if (caps.getos() in (caps.OSName.RHEVH, caps.OSName.RHEL) and Line 40: caps.osversion()['version'].startswith('6')): Line 41: version_info.update( Line 42: { this indentation is very uncommon to vdsm Line 43: 'supportedENGINEs': ['3.0', '3.1', '3.2', '3.3', '3.4', '3.5'], Line 44: 'supportedProtocols': ['2.2', '2.3'], Line 45: 'clusterLevels': ['3.0', '3.1', '3.2', '3.3', '3.4', '3.5'], Line 46: } Line 40: caps.osversion()['version'].startswith('6')): Line 41: version_info.update( Line 42: { Line 43: 'supportedENGINEs': ['3.0', '3.1', '3.2', '3.3', '3.4', '3.5'], Line 44: 'supportedProtocols': ['2.2', '2.3'], please move supportedProtocols to the common area (and drop in another patch for master) Line 45: 'clusterLevels': ['3.0', '3.1', '3.2', '3.3', '3.4', '3.5'], Line 46: } Line 47: ) Line 48: else: -- To view, visit https://gerrit.ovirt.org/42247 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55f5aec924e917db4c0abdcf8ee75fdbd9555c22 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
