Dan Kenigsberg has posted comments on this change.

Change subject: Modifying vdsm supported cluster end engine versions for  el6 
and el7
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/42247/5/vdsm/dsaversion.py.in
File vdsm/dsaversion.py.in:

Line 31: software_revision = "@PACKAGE_RELEASE@"
Line 32: raw_version_revision = "@PACKAGE_VERSION@.@PACKAGE_RELEASE@"
Line 33: 
Line 34: 
Line 35: def is_el6():
If duplicating the code is what you want, let it go in...
Line 36:     def _parseKeyVal(lines, delim='='):
Line 37:         d = {}
Line 38:         for line in lines:
Line 39:             kv = line.split(delim, 1)


-- 
To view, visit https://gerrit.ovirt.org/42247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55f5aec924e917db4c0abdcf8ee75fdbd9555c22
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to