Francesco Romani has posted comments on this change. Change subject: virt: Safe device type check for console device ......................................................................
Patch Set 1: Code-Review-1 (1 comment) -1 for visibility and discussion toward a definitive fix. https://gerrit.ovirt.org/#/c/42881/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3907: if not hasattr(dev, 'alias'): Line 3908: dev.alias = alias Line 3909: Line 3910: for dev in self.conf['devices']: Line 3911: if dev.get('device') == hwclass.CONSOLE and \ we hit this one time for rng devices, but now I'm starting to see one pattern. The first question is: shouldn't Engine send 'device' field? VDSM expects this, as thes BZs demonstrate. Line 3912: not dev.get('alias'): Line 3913: dev['alias'] = alias Line 3914: Line 3915: def _getUnderlyingSmartcardDeviceInfo(self): -- To view, visit https://gerrit.ovirt.org/42881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a0c1adc6c3b2ab8d50b6e3ac712ce2dcf04cc6c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Shmuel Leib Melamud <[email protected]> Gerrit-Reviewer: Shmuel Melamud <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
