Amador Pahim has posted comments on this change. Change subject: hook: diskunmap: To include UNMAP support for disk and lun devices ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/29770/7/vdsm_hooks/diskunmap/before_vm_start.py File vdsm_hooks/diskunmap/before_vm_start.py: Line 43: device = disk.getAttribute('device') Line 44: target = disk.getElementsByTagName('target')[0] Line 45: bus = target.getAttribute('bus') Line 46: if ((device == 'disk' or device == 'lun') Line 47: and (bus == 'scsi' or bus == 'ide')): > Why not virtio? virtio does not support discard. Only IDE and virtio-scsi do. Line 48: driver = disk.getElementsByTagName('driver')[0] Line 49: driver.setAttribute('discard', 'unmap') Line 50: Line 51: -- To view, visit https://gerrit.ovirt.org/29770 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36385f1af24043755b3d4b6594bbe598b0d9518d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
