Dan Kenigsberg has submitted this change and it was merged. Change subject: hook: diskunmap: To include UNMAP support for disk and lun devices ......................................................................
hook: diskunmap: To include UNMAP support for disk and lun devices This hook goes through VM definitions xml file and manipulate its disk device if it "disk" or "lun" and if the bus is "scsi" or "ide", adding "discard=unmap" option to "-drive" qemu command line patameter. UNMAP support was introduced by qemu 1.5 and it's intended to return the unused/freed blocks back to the storage, specially useful for thin provisioned LUNs. Result example: <disk device="disk" snapshot="no" type="block"> ... <target bus="ide" dev="hda"/> ... <driver cache="none" discard="unmap" ... /> </disk> <disk device="lun" sgio="filtered" snapshot="no" type="block"> ... <target bus="scsi" dev="sda"/> ... <driver cache="none" discard="unmap" ... /> </disk> Change-Id: I36385f1af24043755b3d4b6594bbe598b0d9518d Signed-off-by: Amador Pahim <apa...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/29770 Reviewed-by: Fabian Deutsch <fabi...@redhat.com> Reviewed-by: Francesco Romani <from...@redhat.com> Reviewed-by: Michal Skrivanek <michal.skriva...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> Continuous-Integration: Dan Kenigsberg <dan...@redhat.com> --- M configure.ac M vdsm.spec.in M vdsm_hooks/Makefile.am A vdsm_hooks/diskunmap/Makefile.am A vdsm_hooks/diskunmap/README A vdsm_hooks/diskunmap/before_vm_start.py 6 files changed, 178 insertions(+), 0 deletions(-) Approvals: Fabian Deutsch: Looks good to me, but someone else must approve Amador Pahim: Verified Dan Kenigsberg: Looks good to me, approved; Passed CI tests Francesco Romani: Looks good to me, but someone else must approve Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/29770 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36385f1af24043755b3d4b6594bbe598b0d9518d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <apa...@redhat.com> Gerrit-Reviewer: Amador Pahim <apa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Yoav Kleinberger <yklei...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches