Ala Hino has posted comments on this change. Change subject: gluster: Verify volume is Replica 3 ......................................................................
Patch Set 38: (1 comment) https://gerrit.ovirt.org/#/c/41931/38/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 314: self.log.warn("Using user specified backup-volfile-servers option") Line 315: return "" Line 316: Line 317: volinfo = supervdsm.getProxy().glusterVolumeInfo(self._volname, Line 318: self._volfileServer) > This patch does not make sense - why are you duplicating the call to gluste I agree that the duplicate calls are bad. I was thinking that introducing volinfo property without "real" reason would be questioned. Anyway, this is done. Line 319: servers = [brick.split(":")[0] Line 320: for brick in volinfo[self._volname]['bricks']] Line 321: servers.remove(self._volfileServer) Line 322: if not servers: -- To view, visit https://gerrit.ovirt.org/41931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f Gerrit-PatchSet: 38 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
