Nir Soffer has posted comments on this change. Change subject: gluster: Verify volume is Replica 3 ......................................................................
Patch Set 40: Code-Review-1 (2 comments) -1 for visibility https://gerrit.ovirt.org/#/c/41931/40/tests/storageServerTests.py File tests/storageServerTests.py: Line 124: Line 125: def glusterVolumeInfo(volname=None, volfileServer=None): Line 126: return None Line 127: Line 128: storageServer.supervdsm.glusterVolumeInfo = glusterVolumeInfo This may be needed by older versions on this patch, but now it should not be needed. When we access gluster.options, we don't access gluster.volinfo because we return early if self._options contains the backup-volfile-servers option. Line 129: Line 130: user_options = "backup-volfile-servers=server1:server2" Line 131: gluster = GlusterFSConnection(spec="192.168.122.1:/music", Line 132: options=user_options) https://gerrit.ovirt.org/#/c/41931/40/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 298 Line 299 Line 300 Line 301 Line 302 This check should be in options() - you should not access self._options in many places, better access it only in options() and let other code access self.options. -- To view, visit https://gerrit.ovirt.org/41931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f Gerrit-PatchSet: 40 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
