Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: vdscli: migration: fix migrationCreate ......................................................................
Patch Set 3: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/42970/3/lib/vdsm/jsonrpcvdscli.py File lib/vdsm/jsonrpcvdscli.py: Line 60: if resp.error is not None: Line 61: return response.error_raw(resp.error["code"], Line 62: resp.error["message"]) Line 63: Line 64: res = response.success() pardon my heap overflow, but with "response" and "resp" already defined, "res" is too much. can you think of a more specific name? Line 65: if resp.result and resp.result is not True: Line 66: # None is translated to True inside our JSONRPC implementation Line 67: res.update(resp.result) Line 68: return res -- To view, visit https://gerrit.ovirt.org/42970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9288d367c519830f6510a2d1b2a5fc1e410949c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
