Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpc: vdscli: migration: fix migrationCreate ......................................................................
jsonrpc: vdscli: migration: fix migrationCreate In virt migration code, we do logic on the return value of VM.migrationCreate API, and we expect it to be a proper response, so with ['status']['code'] field, plus all the extra fields that APIs can add (see schema for examples). Current jsonrpc code strips all but the extra fields, so jsonrpcvdscli has to force fit a success code. This patch simplify the code by just passing around a copy of the raw data, leveraging the response module. This way the code is both simpler and more conformant to the old XML-RPC vdscli API. Change-Id: Ie9288d367c519830f6510a2d1b2a5fc1e410949c Signed-off-by: Francesco Romani <from...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/42970 Reviewed-by: Piotr Kliczewski <piotr.kliczew...@gmail.com> Continuous-Integration: Jenkins CI Reviewed-by: Vinzenz Feenstra <vfeen...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M lib/vdsm/jsonrpcvdscli.py 1 file changed, 8 insertions(+), 5 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Vinzenz Feenstra: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/42970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9288d367c519830f6510a2d1b2a5fc1e410949c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
