Federico Simoncelli has posted comments on this change.

Change subject: Provisional fix: the domain is produced in the monitor thread.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

Downvoting for an open question and because it needs rebasing.

....................................................
File vdsm/storage/domainMonitor.py
Line 110:         for sdUUID in self._domains.keys():
Line 111:             self.stopMonitoring(sdUUID)
Line 112: 
Line 113:     def _monitorDomain(self, sdUUID, hostId, stopEvent, status):
Line 114:         domain = sdCache.produce(sdUUID)
What if the produce throws an exception? The thread is going to die and nobody 
would notice?
Line 115:         nextStatus = DomainMonitorStatus()
Line 116:         isIsoDomain = domain.isISO()
Line 117:         lastRefresh = time()
Line 118:         refreshTime = config.getint("irs", 
"repo_stats_cache_refresh_timeout")


--
To view, visit http://gerrit.ovirt.org/7163
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to