Federico Simoncelli has posted comments on this change.
Change subject: Provisional fix: the domain is produced in the monitor thread.
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/domainMonitor.py
Line 121: self.refreshTime = \
Line 122: config.getint("irs",
"repo_stats_cache_refresh_timeout")
Line 123:
Line 124: def start(self):
Line 125: self.domain = sdCache.produce(self.sdUUID)
I think that the problem persists. What if this throws an exception? We'll have
the domain monitor in self._domains but the thread failed to start (who is
going to cleanup self._domains[sdUUID]?).
Line 126: self.isIsoDomain = self.domain.isISO()
Line 127: self.thread.start()
Line 128:
Line 129: def stop(self, wait=True):
--
To view, visit http://gerrit.ovirt.org/7163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches