Dan Kenigsberg has posted comments on this change. Change subject: net: introducing KernelConfig ......................................................................
Patch Set 4: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/42960/4/lib/vdsm/netconfpersistence.py File lib/vdsm/netconfpersistence.py: Line 246: attributes['ipaddr'] = net_attr['addr'] Line 247: if net_attr['netmask']: Line 248: attributes['netmask'] = net_attr['netmask'] Line 249: if net_attr['gateway']: Line 250: attributes['gateway'] = net_attr['gateway'] please consider unindenting the following block Line 251: non_local_addresses = self._translate_ipv6_addr( Line 252: net_attr['ipv6addrs']) Line 253: if non_local_addresses: Line 254: attributes['ipv6addr'] = non_local_addresses -- To view, visit https://gerrit.ovirt.org/42960 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79f1eb553a42f1398ad12aa1bc33522f8af30c79 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
