Dan Kenigsberg has posted comments on this change. Change subject: net: introducing KernelConfig ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/42960/4/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 64: IP_GATEWAY = '240.0.0.254' Line 65: DHCP_RANGE_FROM = '240.0.0.10' Line 66: DHCP_RANGE_TO = '240.0.0.100' Line 67: CUSTOM_PROPS = {'linux': 'rules', 'vdsm': 'as well'} Line 68: IP_MASK = '255.255.255.0' still here Line 69: IPv6_ADDRESS = 'fdb3:84e5:4ff4:55e3::1/64' Line 70: IPv6_GATEWAY = 'fdb3:84e5:4ff4:55e3::ff' Line 71: Line 72: dummyPool = set() Line 725: @permutations([[True], [False]]) Line 726: @RequireDummyMod Line 727: @ValidateRunningAsRoot Line 728: @brokentest('This test is known to break until initscripts-9.03.41-1.el6 ' Line 729: 'is released to fix https://bugzilla.redhat.com/1086897') still here Line 730: def testSetupNetworksAddVlan(self, bridged): Line 731: BRIDGE_OPTS = {'multicast_router': '0', 'multicast_snooping': '0'} Line 732: formattedOpts = ' '.join( Line 733: ['='.join(elem) for elem in BRIDGE_OPTS.items()]) -- To view, visit https://gerrit.ovirt.org/42960 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79f1eb553a42f1398ad12aa1bc33522f8af30c79 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
