Dima Kuznetsov has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/43211/4/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 73: (sleep 20 && echodo $REBOOTCMD) & Line 74: disown Line 75: (sleep 7 Line 76: log "Trying to stop vdsm for sdUUID=$sdUUID id=$ID lease_path=$LEASE_FILE" Line 77: echodo $SYSTEMCTL restart vdsmd.service > We are not getting rid of this code soon, we must support this for few year Well, it looks like sysvinit (used to) run {super,}vdsmd with respawn, so basically this gets rid of the running vdsm instance and brings up a fresh one. I'll send a version with your suggestions but I propose we think of a prettier way to interact with systemd services. Line 78: )& Line 79: disown Line 80: Line 81: echodo $SYSTEMCTL kill --signal=30 vdsmd.service -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches