Nir Soffer has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/43211/4/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 77: echodo $SYSTEMCTL restart vdsmd.service Line 78: )& Line 79: disown Line 80: Line 81: echodo $SYSTEMCTL kill --signal=30 vdsmd.service > Nir, I think you just afraid of regressions and try to avoid verification f Yaniv, systemctl stop vdsmd can take up to 20 seconds - this is not a replacement for kill -9. Please read my previous comments. Line 82: Line 83: rm -fr $RENEWDIR Line 84: trap EXIT Line 85: exit 3 -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
