Dan Kenigsberg has submitted this change and it was merged. Change subject: StorageDomainManifest: introduce class heirarchy ......................................................................
StorageDomainManifest: introduce class heirarchy Many of the functions in the StorageDomain class family serve to provide information about the storage domain and its contents (ie. images and volumes). Other functions manipulate image or volume metadata in a fine-grained, reusable way (ie. extendVolume). As we refactor the storage code to operate without an SPM the new code will benefit from reusing these Storage Domain "manifest" functions. In order to make reuse clean and safe, we want to refactor the StorageDomain class by splitting the reusable elements into a StorageDomainManifest class. The StorageDomain object will initialize and use a StorageDomainManifest object for much of its normal operations. Meanwhile, the new SDM code may use a StorageDomainManifest object directly without having access to the non-sharable parts of StorageDomain. In an effort to reduce churn during the refactoring, when moving a method into its new class, I will leave behind a stub in the original class which simply passes the call through to the method's new location. Once all code has been refactored, I'll remove stubs for any methods which are not currently accessed outside of the class. This patch removes volumeTests.FileVolumeGetVSizeTest since it is not really a Volume test and it would be broken by this patch anyway. It will be restored as a storageDomainManifestTest in a followup patch. Change-Id: Ia275424a8d423722efb229a4d8545f035fe5fa51 Signed-off-by: Adam Litke <[email protected]> Reviewed-on: https://gerrit.ovirt.org/41993 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer <[email protected]> Reviewed-by: Federico Simoncelli <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- A tests/manifest_tests.py A tests/storagefakelib.py M tests/volumeTests.py M vdsm/storage/blockSD.py M vdsm/storage/fileSD.py M vdsm/storage/imageRepository/formatConverter.py M vdsm/storage/sd.py 7 files changed, 197 insertions(+), 81 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Adam Litke: Verified Federico Simoncelli: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41993 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia275424a8d423722efb229a4d8545f035fe5fa51 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
