Dan Kenigsberg has submitted this change and it was merged. Change subject: StorageDomainManifest: move BlockSD.getVSize ......................................................................
StorageDomainManifest: move BlockSD.getVSize getVSize is one of the first functions needed by the VolumeMetadata refactoring later on in the series. BlockVolume.getVolumeSize currently calls into the StorageDomain to get the volume size. Since VolumeMetadata cannot create StorageDomain objects we move getVSize into the manifest which can be safely instantiated. Tests added: - file: getVSize using fake volume - block: getVSize via lvm - block: getVSize by examining "device" file Change-Id: Ib00eba218cfb4af201aebcdc5071f95164c31687 Signed-off-by: Adam Litke <[email protected]> Reviewed-on: https://gerrit.ovirt.org/41994 Reviewed-by: Nir Soffer <[email protected]> Continuous-Integration: Jenkins CI Reviewed-by: Federico Simoncelli <[email protected]> --- M tests/manifest_tests.py M tests/storagefakelib.py M vdsm/storage/blockSD.py M vdsm/storage/fileSD.py M vdsm/storage/sd.py 5 files changed, 172 insertions(+), 22 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Adam Litke: Verified Federico Simoncelli: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/41994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib00eba218cfb4af201aebcdc5071f95164c31687 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
