Nir Soffer has posted comments on this change. Change subject: StorageDomainManifest: move BlockSD.getVSize ......................................................................
Patch Set 14: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/41994/14/tests/storagefakelib.py File tests/storagefakelib.py: Line 100: Line 101: def getLV(self, vgName, lvName): Line 102: lv_md = deepcopy(self.lvmd[vgName][lvName]) Line 103: lv_attr = real_lvm.LV_ATTR(**lv_md['attr']) Line 104: lv_md['attr'] = lv_attr I think doing the attr replacement in one line will be more clear: lv_md['attr'] = real_lvm.LV_ATTR(**lv_md['attr']) Line 105: return real_lvm.LV(**lv_md) Line 106: Line 107: def fake_lv_symlink_create(self, vg_name, lv_name): Line 108: volpath = self.lvPath(vg_name, lv_name) -- To view, visit https://gerrit.ovirt.org/41994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib00eba218cfb4af201aebcdc5071f95164c31687 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
