Dan Kenigsberg has submitted this change and it was merged. Change subject: StorageDomainManifest: move path getters ......................................................................
StorageDomainManifest: move path getters getLeasesFilePath is needed by VolumeMetadata to implement the newVolumeLease function on block storage. Move it into the Manifest class which can be safely instantiated. Also move topically similar getIdsFilePath and getIsoDomainImagesDir. Tests: - file: get the metadata path - file: get the iso domain images path Change-Id: I2bb49591357e0ae77268789da78e8504864a8057 Signed-off-by: Adam Litke <[email protected]> Reviewed-on: https://gerrit.ovirt.org/41995 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer <[email protected]> Reviewed-by: Federico Simoncelli <[email protected]> --- M tests/manifest_tests.py M vdsm/storage/blockSD.py M vdsm/storage/fileSD.py M vdsm/storage/sd.py 4 files changed, 44 insertions(+), 17 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Adam Litke: Verified Federico Simoncelli: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/41995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bb49591357e0ae77268789da78e8504864a8057 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
