Ayal Baron has posted comments on this change. Change subject: BZ#846323 - Search PV's belonging to the VG in removeVG. ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2012-08-09 18:41:47 +0300 Line 4: Commit: Eduardo Warszawski <[email protected]> Line 5: CommitDate: 2012-08-09 19:00:27 +0300 Line 6: Line 7: BZ#846323 - Search PV's belonging to the VG in removeVG. why? Line 8: Line 9: Only one getAllPvs() call remains! Line 10: Line 11: Change-Id: Ica565f74774fd1dcce7c18361aef5e1464c78b68 .................................................... File vdsm/storage/lvm.py Line 864: rc, out, err = _lvminfo.cmd(cmd) Line 865: if rc != 0: Line 866: log.error("Getting pvs for vg %s failed. (%s, %s, %s)", Line 867: vgName, rc, out, err) Line 868: # _lvminfo._invalidateAllPvs() # Let's discusse this this code is too complicated. The function should be: vgremove invalidateAllPVs That's it. Line 869: pvs = tuple() Line 870: else: Line 871: pvs = tuple(pvName.strip() for pvName in out) Line 872: # Remove the vg from the cache -- To view, visit http://gerrit.ovirt.org/7066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica565f74774fd1dcce7c18361aef5e1464c78b68 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Paikov <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
