Ayal Baron has posted comments on this change. Change subject: BZ#846323 - Search PV's belonging to the VG in removeVG. ......................................................................
Patch Set 3: I would prefer that you didn't submit this (2 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2012-08-09 18:41:47 +0300 Line 4: Commit: Eduardo Warszawski <[email protected]> Line 5: CommitDate: 2012-08-28 11:45:53 +0300 Line 6: Line 7: BZ#846323 - Search PV's belonging to the VG in removeVG. you still haven't commented on "why" Line 8: Line 9: Only one getAllPvs() call remains! Line 10: Line 11: Change-Id: Ica565f74774fd1dcce7c18361aef5e1464c78b68 .................................................... File vdsm/storage/lvm.py Line 859: Line 860: Line 861: def removeVG(vgName): Line 862: # Remove the vg from the cache Line 863: _lvminfo._vgs.pop(vgName, None) this also has a race. the vg should be removed after vgremove is called (or both before and after) Line 864: # and now destroy it Line 865: cmd = ["vgremove", "-f", vgName] Line 866: rc, out, err = _lvminfo.cmd(cmd) Line 867: pvs = tuple(pv for pv in _lvminfo._pvs.iterkeys() -- To view, visit http://gerrit.ovirt.org/7066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica565f74774fd1dcce7c18361aef5e1464c78b68 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Paikov <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
