Nir Soffer has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/43211/5/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 73: (sleep 20 && echodo $REBOOTCMD) & Line 74: disown Line 75: (sleep 7 Line 76: log "Trying to stop vdsm for sdUUID=$sdUUID id=$ID lease_path=$LEASE_FILE" Line 77: echodo $SYSTEMCTL kill --signal=$(kill -t SIGTERM) vdsmd.service > +1 for names, the numbers themselves are not portable across architectures. Right, lets use the names. Line 78: sleep 2 Line 79: echodo $SYSTEMCTL kill --signal=$(kill -t SIGKILL) vdsmd.service Line 80: )& Line 81: disown -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
