Dan Kenigsberg has posted comments on this change. Change subject: vdsm-reg: remove the sub-project ......................................................................
Patch Set 1: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/43254/1/configure.ac File configure.ac: Line 331: AC_PATH_PROG([TAR_PATH], [tar], [/bin/tar]) Line 332: AC_PATH_PROG([TC_PATH], [tc], [/sbin/tc]) Line 333: AC_PATH_PROG([TEE_PATH], [tee], [/usr/bin/tee]) Line 334: AC_PATH_PROG([TOUCH_PATH], [touch], [/bin/touch]) Line 335: AC_PATH_PROG([TUNE2FS_PATH], [tune2fs], [/sbin/tune2fs]) please check which of -EX_CAT = '@CAT_PATH@' -EX_CHKCONFIG = '@CHKCONFIG_PATH@' -EX_DMIDECODE = '@DMIDECODE_PATH@' -EX_ECHO = '@ECHO_PATH@' -EX_GRUBBY = '@GRUBBY_PATH@' -EX_HWCLOCK = '@HWCLOCK_PATH@' -EX_NTPQ = '@NTPQ_PATH@' -EX_OPENSSL = '@OPENSSL_PATH@' -EX_REBOOT = '@REBOOT_PATH@' -EX_RPM = '@RPM_PATH@' -EX_SED = '@SED_PATH@' -EX_SERVICE = '@SERVICE_PATH@' -EX_SYSTEMCTL = '@SYSTEMCTL_PATH@' -EX_YUM = '@YUM_PATH@' can now be dropped from configure.ac Line 336: AC_PATH_PROG([UDEVADM_PATH], [udevadm], [/sbin/udevadm]) Line 337: AC_PATH_PROG([UMOUNT_PATH], [umount], [/bin/umount]) Line 338: AC_PATH_PROG([WGET_PATH], [wget], [/usr/bin/wget]) Line 339: AC_PATH_PROG([YUM_PATH], [yum], [/usr/bin/yum]) https://gerrit.ovirt.org/#/c/43254/1/vdsm_reg/Makefile.am File vdsm_reg/Makefile.am: Line 54 Line 55 Line 56 Line 57 Line 58 all dropped *.in files should be cleaned from .gitignore, too. https://gerrit.ovirt.org/#/c/43254/1/vdsm_reg/deployUtil.py.in File vdsm_reg/deployUtil.py.in: Line 85 Line 86 Line 87 Line 88 Line 89 vdsm/{add,del}Network can (and should) be dropped now. -- To view, visit https://gerrit.ovirt.org/43254 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d19ddb0e65657515e2dc0eb9eeae320d8d6bf71 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
