Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-reg: remove the sub-project ......................................................................
Patch Set 1: (7 comments) Fabian, I will update the commit msg https://gerrit.ovirt.org/#/c/43254/1/configure.ac File configure.ac: Line 331: AC_PATH_PROG([TAR_PATH], [tar], [/bin/tar]) Line 332: AC_PATH_PROG([TC_PATH], [tc], [/sbin/tc]) Line 333: AC_PATH_PROG([TEE_PATH], [tee], [/usr/bin/tee]) Line 334: AC_PATH_PROG([TOUCH_PATH], [touch], [/bin/touch]) Line 335: AC_PATH_PROG([TUNE2FS_PATH], [tune2fs], [/sbin/tune2fs]) > please check which of EX_CAT is used vdsm/sudoers.vdsm.in Line 336: AC_PATH_PROG([UDEVADM_PATH], [udevadm], [/sbin/udevadm]) Line 337: AC_PATH_PROG([UMOUNT_PATH], [umount], [/bin/umount]) Line 338: AC_PATH_PROG([WGET_PATH], [wget], [/usr/bin/wget]) Line 339: AC_PATH_PROG([YUM_PATH], [yum], [/usr/bin/yum]) Line 332: AC_PATH_PROG([TC_PATH], [tc], [/sbin/tc]) Line 333: AC_PATH_PROG([TEE_PATH], [tee], [/usr/bin/tee]) Line 334: AC_PATH_PROG([TOUCH_PATH], [touch], [/bin/touch]) Line 335: AC_PATH_PROG([TUNE2FS_PATH], [tune2fs], [/sbin/tune2fs]) Line 336: AC_PATH_PROG([UDEVADM_PATH], [udevadm], [/sbin/udevadm]) DMIDECODE_PATH is used in: lib/vdsm/constants.py vdsm/sudoers.vdsm.in Line 337: AC_PATH_PROG([UMOUNT_PATH], [umount], [/bin/umount]) Line 338: AC_PATH_PROG([WGET_PATH], [wget], [/usr/bin/wget]) Line 339: AC_PATH_PROG([YUM_PATH], [yum], [/usr/bin/yum]) Line 340: Line 333: AC_PATH_PROG([TEE_PATH], [tee], [/usr/bin/tee]) Line 334: AC_PATH_PROG([TOUCH_PATH], [touch], [/bin/touch]) Line 335: AC_PATH_PROG([TUNE2FS_PATH], [tune2fs], [/sbin/tune2fs]) Line 336: AC_PATH_PROG([UDEVADM_PATH], [udevadm], [/sbin/udevadm]) Line 337: AC_PATH_PROG([UMOUNT_PATH], [umount], [/bin/umount]) HWCLOCK_PATH, NTPQ_PATH, EX_REBOOT are used in debian/rules Line 338: AC_PATH_PROG([WGET_PATH], [wget], [/usr/bin/wget]) Line 339: AC_PATH_PROG([YUM_PATH], [yum], [/usr/bin/yum]) Line 340: Line 341: # Keep sorted Line 336: AC_PATH_PROG([UDEVADM_PATH], [udevadm], [/sbin/udevadm]) Line 337: AC_PATH_PROG([UMOUNT_PATH], [umount], [/bin/umount]) Line 338: AC_PATH_PROG([WGET_PATH], [wget], [/usr/bin/wget]) Line 339: AC_PATH_PROG([YUM_PATH], [yum], [/usr/bin/yum]) Line 340: OPENSSL_PATH is used in lib/vdsm/tool/validate_ovirt_certs.py.in Line 341: # Keep sorted Line 342: AC_OUTPUT([ Line 343: Makefile Line 344: client/Makefile Line 337: AC_PATH_PROG([UMOUNT_PATH], [umount], [/bin/umount]) Line 338: AC_PATH_PROG([WGET_PATH], [wget], [/usr/bin/wget]) Line 339: AC_PATH_PROG([YUM_PATH], [yum], [/usr/bin/yum]) Line 340: Line 341: # Keep sorted SERVICE_PATH is used in debian/rules and vdsm/sudoers.vdsm.in Line 342: AC_OUTPUT([ Line 343: Makefile Line 344: client/Makefile Line 345: contrib/Makefile https://gerrit.ovirt.org/#/c/43254/1/vdsm.spec.in File vdsm.spec.in: Line 609: %endif Line 610: %configure %{?with_hooks:--enable-hooks} \ Line 611: %{rhev_build_config_opt} \ Line 612: %if 0%{?rhev_build} Line 613: --with-reg-bridge-name='rhevm' \ > this should be drooped too ^ Done Line 614: --with-engine-name='RHEV-M' \ Line 615: --with-smbios-manufacturer='Red Hat' \ Line 616: --with-smbios-osname='RHEV Hypervisor' \ Line 617: --with-qemu-kvm='qemu-kvm-rhev' \ Line 615: --with-smbios-manufacturer='Red Hat' \ Line 616: --with-smbios-osname='RHEV Hypervisor' \ Line 617: --with-qemu-kvm='qemu-kvm-rhev' \ Line 618: --with-qemu-img='qemu-img-rhev' \ Line 619: --with-register-uri='/RHEVManagerWeb/VdsAutoRegistration.aspx' > and this one, too ^^ Done Line 620: %endif Line 621: Line 622: make Line 623: # Setting software_version and software_revision in dsaversion.py -- To view, visit https://gerrit.ovirt.org/43254 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d19ddb0e65657515e2dc0eb9eeae320d8d6bf71 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
