Nir Soffer has posted comments on this change. Change subject: jsonrpc: executor based thread factory ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/43759/1/vdsm/rpc/bindingjsonrpc.py File vdsm/rpc/bindingjsonrpc.py: Line 64: def __init__(self, bridge, subs, timeout): Line 65: _scheduler.start() Line 66: _executor.start() Line 67: Line 68: self._server = JsonRpcServer(bridge, timeout, _executorFactory) > Use executor.dispatch as the threadFactory. But note that the executor may raise TooManyTasks - you must handle this exception in the jsonrpc server, and maybe send an error to the client, about server being too busy. This also require handling such errors in the engine side. Line 69: self._reactor = StompReactor(subs) Line 70: self.startReactor() Line 71: Line 72: def add_socket(self, reactor, client_socket): -- To view, visit https://gerrit.ovirt.org/43759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
