Nir Soffer has posted comments on this change. Change subject: jsonrpc: executor based thread factory ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/43759/2/vdsm/rpc/bindingjsonrpc.py File vdsm/rpc/bindingjsonrpc.py: Line 24: Line 25: Line 26: # TODO test what should be the default values Line 27: _THREADS = config.getint('vars', 'worker_threads') Line 28: _TASK_PER_WORKER = config.getint('vars', 'tasks_per_worker') > OK. will update. Since you plan to an executor for xmlrpc, we can consider having [rpc] section for specifying the number of threads/tasks. Line 29: _TASKS = _THREADS * _TASK_PER_WORKER Line 30: Line 31: Line 32: class BindingJsonRpc(object): -- To view, visit https://gerrit.ovirt.org/43759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
