Ido Barkan has posted comments on this change.

Change subject: net: run dhclient in its own process group.
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/43853/4/lib/vdsm/cmdutils.py
File lib/vdsm/cmdutils.py:

Line 21: 
Line 22: 
Line 23: def systemd_run(cmd, scope=False, unit=None, slice=None):
Line 24:     # warning: this is supported only on OS versions that use systemd 
(el7 and
Line 25:     # later).
> The word "warning" is unneeded.
Done
Line 26:     command = [constants.EXT_SYSTEMD_RUN]
Line 27:     if scope:
Line 28:         command.append('--scope')
Line 29:     if unit:


-- 
To view, visit https://gerrit.ovirt.org/43853
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82848a36b52cd8e9dec188d865ef86edc4bb7488
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Ido Barkan <ibar...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to