Nir Soffer has posted comments on this change. Change subject: net: run dhclient in its own process group. ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/43853/6/vdsm/network/configurators/dhclient.py File vdsm/network/configurators/dhclient.py: Line 57: kill_dhclient(self.iface) Line 58: cmd = [self.DHCLIENT.cmd, '-1', '-pf', self.pidFile, '-lf', Line 59: self.leaseFile, self.iface] Line 60: if not EL6: Line 61: cmd = cmdutils.systemd_run(cmd, scope=True, slice=self._cgroup) > this code should check if self._cgroup is not None. same as in ifcfg.py Is it the same as master now? If master does not check for None, I would add this in a separate patch in both master/3.5. Line 62: Line 63: rc, out, err = execCmd(cmd) Line 64: return rc, out, err Line 65: -- To view, visit https://gerrit.ovirt.org/43853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82848a36b52cd8e9dec188d865ef86edc4bb7488 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
