Freddy Rolland has posted comments on this change. Change subject: storageServer: Add tests for equality and hash ......................................................................
Patch Set 2: Code-Review+1 (3 comments) https://gerrit.ovirt.org/#/c/43988/2//COMMIT_MSG Commit Message: Line 9: tets tets->tests https://gerrit.ovirt.org/#/c/43988/2/tests/storageServerTests.py File tests/storageServerTests.py: Line 124: diffrent diffrent->different Line 124: def test_not_equal_diffrent_hash(self, s1, s2, t1, t2, o1, o2): Why do we need this test ? I thought the contract should be: 1. If two objects are equal, then they must have the same hash code. 2. If two objects have the same hashcode, they may or may not be equal. -- To view, visit https://gerrit.ovirt.org/43988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1dc9510a9f0f6c44534fd568cbcda161f36497c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
