Dan Kenigsberg has submitted this change and it was merged. Change subject: storageServer: Add tests for equality and hash ......................................................................
storageServer: Add tests for equality and hash Current __eq__ and __hash__ are wrong and have no tests. Add tests showing what works and what not. To make the tests results more clear, implement __str__. This can also be useful when logging the objects. Change-Id: Ie1dc9510a9f0f6c44534fd568cbcda161f36497c Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/43988 Continuous-Integration: Jenkins CI Reviewed-by: Freddy Rolland <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M tests/storageServerTests.py M vdsm/storage/storageServer.py 2 files changed, 69 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1dc9510a9f0f6c44534fd568cbcda161f36497c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
