Dan Kenigsberg has posted comments on this change. Change subject: tcTests: Fix problem of left over bridges ......................................................................
Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/44028/1/tests/tcTests.py File tests/tcTests.py: Line 106: def delDevice(self): Line 107: try: Line 108: self._ifDown() Line 109: check_call([EXT_BRCTL, 'delbr', self.devName]) Line 110: except ExecError: tabs are evil Line 111: # Sometimes the bridge is not shut down, although ip reports so. Line 112: # Just retrying the shutdown and the removal once is enough to Line 113: # work around that. Line 114: self._ifDown() Line 107: try: Line 108: self._ifDown() Line 109: check_call([EXT_BRCTL, 'delbr', self.devName]) Line 110: except ExecError: Line 111: # Sometimes the bridge is not shut down, although ip reports so. this is very odd. https://gerrit.ovirt.org/41362 attempted to wait until it was fully down. any idea what else should we wait for? Line 112: # Just retrying the shutdown and the removal once is enough to Line 113: # work around that. Line 114: self._ifDown() Line 115: check_call([EXT_BRCTL, 'delbr', self.devName]) -- To view, visit https://gerrit.ovirt.org/44028 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd0d8f20283fdf80977bd1f78f5b2ac62f7e83c8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roman Mohr <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
