Dan Kenigsberg has posted comments on this change.
Change subject: BZ#811807 Libvirt service engagement workaround
......................................................................
Patch Set 1: (3 inline comments)
arghh, that's ugly - but not your fault, and I have no better idea.
....................................................
File vdsm/vdsmd.init.in
Line 442: then
Line 443:
Line 444: # Begin workaround
Line 445: # Libvirt reports its service status as responsive despite
its socket
Line 446: # is not yet ready. Once issue fixed on libvirt, this WA
shouls be removed.
please keep new code in short lines.
Line 447: for i in {1..20}
Line 448: do
Line 449: if pgrep libvirtd > /dev/null 2>&1;
Line 450: then
Line 449: if pgrep libvirtd > /dev/null 2>&1;
Line 450: then
Line 451: return 0
Line 452: fi
Line 453: sleep 1
do you have an estimate for a common waiting time? maybe we can `sleep 0.2` and
improve latency?
Line 454: done
Line 455: # End workaround
Line 456:
Line 457: return 0
Line 450: then
Line 451: return 0
Line 452: fi
Line 453: sleep 1
Line 454: done
I'd put this workaround into a separate function, and log an error if our 20
second timeout has expired with no libvirtd seen.
Line 455: # End workaround
Line 456:
Line 457: return 0
Line 458: else
--
To view, visit http://gerrit.ovirt.org/7361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
