Dan Kenigsberg has posted comments on this change.
Change subject: Libvirt service engagement workaround
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
sorry for not thinking about this before.
....................................................
File vdsm/vdsmd.init.in
Line 433: fi
Line 434: sleep 0.2
Line 435: done
Line 436:
Line 437: log_failure_msg "$prog: failed to connect to libvirt"
I suppose we need to return failure here...
Line 438: }
Line 439:
Line 440: start_libvirtd() {
Line 441: local packaged target
Line 459: startout=`/sbin/initctl start libvirtd 2>&1`
Line 460: if [[ "$?" -eq 0 || "$startout" =~ .*already\ running.* ]];
Line 461: then
Line 462: await_libvirt_start_workaround
Line 463: return 0
... and here, with
return $?
Line 464: else
Line 465: echo "$startout" >&2
Line 466: return 1
Line 467: fi
--
To view, visit http://gerrit.ovirt.org/7361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
