Francesco Romani has posted comments on this change. Change subject: vm: fix misleading log of Domain XML ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/44843/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1872: self.log.debug('Detaching device %s from the host.' % Line 1873: dev.device) Line 1874: dev.detach() Line 1875: Line 1876: if not self._incomingMigrationPending(): > Does this mean that if 'restoreState' was in vm's conf, the hook ran and no oops, good catch. Even though I strongly believe it is evil and wrong to run this hook all the times, this is unwanted side effect that should not be hidden here. Will fix, even though I'm pretty sure this will make the code even uglier. Sigh. Line 1877: domxml = hooks.before_vm_start(self._buildDomainXML(), Line 1878: self.conf) Line 1879: # TODO: this is debug information. For 3.6.x we still need to Line 1880: # see the XML even with 'info' as default level. -- To view, visit https://gerrit.ovirt.org/44843 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50f5b8a51830c8ce2a098e4ac11dd1bd6a89aac3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
