Francesco Romani has posted comments on this change. Change subject: vm: fix misleading log of Domain XML ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/44843/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1884: Line 1885: # TODO: ugliest hack ever only to preserve old behaviour. Line 1886: # Must be wiped as soon as the if above is gone. Line 1887: if 'restoreState' in self.conf: Line 1888: hooks.before_vm_start(self._buildDomainXML(), self.conf) amazing to see how much evilness resides in so few lines. Line 1889: Line 1890: if self.recovering: Line 1891: self._dom = NotifyingVirDomain( Line 1892: self._connection.lookupByUUIDString(self.id), -- To view, visit https://gerrit.ovirt.org/44843 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50f5b8a51830c8ce2a098e4ac11dd1bd6a89aac3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
