Ido Barkan has posted comments on this change. Change subject: net: create bond properly during start_devices ......................................................................
Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/44587/1/vdsm/network/configurators/ifcfg.py File vdsm/network/configurators/ifcfg.py: Line 703: Line 704: def start_devices(device_ifcfgs): Line 705: for dev in _sort_device_ifcfgs(device_ifcfgs): Line 706: try: Line 707: if _ifcfg_defines_bonding(dev, device_ifcfgs): reduce this into .startswith() Line 708: with open(netinfo.BONDING_MASTERS, 'w') as bondingMasters: Line 709: bondingMasters.write('+%s\n' % dev) Line 710: _exec_ifup(dev) Line 711: except ConfigNetworkError: Line 705: for dev in _sort_device_ifcfgs(device_ifcfgs): Line 706: try: Line 707: if _ifcfg_defines_bonding(dev, device_ifcfgs): Line 708: with open(netinfo.BONDING_MASTERS, 'w') as bondingMasters: Line 709: bondingMasters.write('+%s\n' % dev) try and except error 17 (file exists) OR copy code from addBonding Line 710: _exec_ifup(dev) Line 711: except ConfigNetworkError: Line 712: logging.error('Failed to ifup device %s during rollback.', dev, Line 713: exc_info=True) -- To view, visit https://gerrit.ovirt.org/44587 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic48f3e8b51e4e7e8668902a785c7c271ada03df6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horacek <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
