Dan Kenigsberg has submitted this change and it was merged. Change subject: net: create bond properly during start_devices ......................................................................
net: create bond properly during start_devices This method, that is used during networks rollback, calls ifup on all ifcfg files it knows of. However, to ifup a bond, one needs to manually create it first, by writing '+bondingName' into /sys/class/net/bonding_masters . Ifcfg configurators already does so when creating bonds. Skipping this step causes ifup to fail and complain: 'Device bond11 does not seem to be present, delaying initialization.' This also fixes testSetupNetworksEmergencyDevicesCleanupBondOverwrite which is almost never run because it is a slow test. Change-Id: Ic48f3e8b51e4e7e8668902a785c7c271ada03df6 Signed-off-by: Ido Barkan <[email protected]> Reviewed-on: https://gerrit.ovirt.org/44587 Reviewed-by: Dan Kenigsberg <[email protected]> Continuous-Integration: Dan Kenigsberg <[email protected]> --- M vdsm/network/configurators/ifcfg.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Ido Barkan: Verified Dan Kenigsberg: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44587 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic48f3e8b51e4e7e8668902a785c7c271ada03df6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horacek <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
