Ondřej Svoboda has posted comments on this change. Change subject: netinfo: make getNicsVlanAndBondingForNetwork more readable, drop asserts ......................................................................
Patch Set 5: Advocacy: I think there's a certain tradeoff between runtime checks and unit and functional tests. I say, let's keep a balance and (as a network guy) I'd rather live with comments and tests than check every condition. If I have it covered by tests I can have a shorter, easier-to-read code. -- To view, visit https://gerrit.ovirt.org/45095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8535dbd29314c97e4519b160a47c9ea6489b5a3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
