Martin Polednik has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/33871/9/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1656: _VMCHANNEL_DEVICE_NAME) Line 1657: domxml._appendAgentDevice(self._qemuguestSocketFile.decode('utf-8'), Line 1658: _QEMU_GA_DEVICE_NAME) Line 1659: Line 1660: if self.arch == caps.Architecture.X86_64: > Could you please elaborate on this? i found surprising we need this only on The PPC archs add this automatically (see https://bugzilla.redhat.com/show_bug.cgi?id=988070). It may not even be needed for x86_64, but let's keep it separate. Line 1661: domxml.appendInput() Line 1662: Line 1663: if self.arch == caps.Architecture.PPC64: Line 1664: domxml.appendEmulator() -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
