Shu Ming has posted comments on this change.
Change subject: Move fencing logic out of API.py
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File vdsm/fenceAgent.py
Line 53:
Line 54: def _buildInput(addr, bladePort, agent, username, password, action,
secure,
Line 55: options):
Line 56: if action not in ('status', 'on', 'off', 'reboot'):
Line 57: raise ValueError('illegal action ' + action)
Suppose I am an administrator, I will look into the log file to find what is
happening in VDSM. You can not suppose administrator to check the console or
the code to know this. IMO, every faulty path should have a log in the log
file. You can argue that many places in VDSM are not doing these, but it is a
good practice for system service program.
Line 58:
Line 59: inp = ('agent=fence_%s\nipaddr=%s\nlogin=%s\noption=%s\n' +
Line 60: 'passwd=%s\n') % (agent, addr, username, action, password)
Line 61:
--
To view, visit http://gerrit.ovirt.org/7190
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I944c6548a42612f705a410fb4290215451bca035
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
